Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude schedules from deleted organizations from notification list #2493

Merged
merged 6 commits into from
Jul 11, 2023

Conversation

Ferril
Copy link
Member

@Ferril Ferril commented Jul 11, 2023

What this PR does

On notifying about shifts change in slack we don't check whether organization was deleted. This PR excludes schedules from deleted organizations from shift notification list

Which issue(s) this PR fixes

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@Ferril Ferril added the pr:no public docs Added to a PR that does not require public documentation updates label Jul 11, 2023
@Ferril Ferril requested a review from a team July 11, 2023 09:35
Copy link
Contributor

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good 👍

looks like we have pre-existing unit tests for these two tasks. We want want to add another test case to ensure it filters out deleted orgs.

@Ferril Ferril added this pull request to the merge queue Jul 11, 2023
Merged via the queue into dev with commit 195181f Jul 11, 2023
@Ferril Ferril deleted the fix-schedules-notification branch July 11, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants