Added resources limits definition for wait-for-db container #2501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
joeyorlando
reviewed
Jul 12, 2023
joeyorlando
reviewed
Jul 12, 2023
joeyorlando
reviewed
Jul 12, 2023
Comment on lines
12
to
18
| resources: | ||
| limits: | ||
| cpu: 100m | ||
| memory: 128Mi | ||
| requests: | ||
| cpu: 100m | ||
| memory: 128Mi |
There was a problem hiding this comment.
Suggested change
| resources: | |
| limits: | |
| cpu: 100m | |
| memory: 128Mi | |
| requests: | |
| cpu: 100m | |
| memory: 128Mi | |
| resources: | |
| limits: | |
| cpu: 100m | |
| memory: 128Mi | |
| requests: | |
| cpu: 100m | |
| memory: 128Mi |
Comment on lines
37
to
43
| resources: | ||
| limits: | ||
| cpu: 100m | ||
| memory: 128Mi | ||
| requests: | ||
| cpu: 100m | ||
| memory: 128Mi |
There was a problem hiding this comment.
Suggested change
| resources: | |
| limits: | |
| cpu: 100m | |
| memory: 128Mi | |
| requests: | |
| cpu: 100m | |
| memory: 128Mi | |
| resources: | |
| limits: | |
| cpu: 100m | |
| memory: 128Mi | |
| requests: | |
| cpu: 100m | |
| memory: 128Mi |
joeyorlando
reviewed
Jul 12, 2023
| @@ -26,6 +34,13 @@ tests: | |||
| set: | |||
| database.type: postgresql | |||
| externalPostgresql.host: some-postgresql-host | |||
| resources: | |||
There was a problem hiding this comment.
Suggested change
| resources: | |
| init.resources: |
actually this probably needs to be set to this. The tests should be failing atm because the wait_for_db_test.yaml.snap still shows:
resources: {}There was a problem hiding this comment.
You were right. Fixed it.
joeyorlando
approved these changes
Jul 12, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
2 checks was Failed i have no idea why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Added 'resources limits' definition for wait-for-db container
Which issue(s) this PR fixes
I face a problem: when i install OnCall by Helm, my pods with oncall-engine and oncall-celery stuck on Init state, because they don't have enough resources to run.
Checklist
CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)pr:no public docsPR label added if not required)