Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default phone provider #2523

Merged
merged 10 commits into from
Jul 17, 2023
Merged

Conversation

sreway
Copy link
Contributor

@sreway sreway commented Jul 13, 2023

What this PR does

Sets a default value for the PHONE_PROVIDER setting and replaces the value of PHONE_PROVIDER with this default value if it is not valid.

Which issue(s) this PR fixes

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@sreway sreway requested a review from a team July 13, 2023 14:57
@Konstantinov-Innokentii Konstantinov-Innokentii added the pr:no public docs Added to a PR that does not require public documentation updates label Jul 17, 2023
@Konstantinov-Innokentii
Copy link
Member

@sreway LGTM, could you please add an entry to the CHANGELOG?

CHANGELOG.md Outdated Show resolved Hide resolved
sreway and others added 2 commits July 17, 2023 14:50
Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com>
CHANGELOG.md Outdated Show resolved Hide resolved
@joeyorlando joeyorlando added this pull request to the merge queue Jul 17, 2023
Merged via the queue into grafana:dev with commit 8644883 Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants