Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paginate calls to get instances from gcom #2669

Merged
merged 5 commits into from
Jul 28, 2023
Merged

Paginate calls to get instances from gcom #2669

merged 5 commits into from
Jul 28, 2023

Conversation

mderynck
Copy link
Contributor

@mderynck mderynck commented Jul 27, 2023 •
edited
Loading

What this PR does

GCOM now has many more instances returned than in the past. Paginate these calls instead of getting all at once.

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@mderynck mderynck added the pr:no public docs Added to a PR that does not require public documentation updates label Jul 27, 2023
@mderynck mderynck requested a review from a team July 27, 2023 22:06
@mderynck mderynck added this pull request to the merge queue Jul 28, 2023
Merged via the queue into dev with commit f201fd2 Jul 28, 2023
@mderynck mderynck deleted the mderynck/paginate-gcom-requests branch July 28, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iskhakov iskhakov iskhakov approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mderynck @iskhakov