Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhooks Public API #2790

Merged
merged 10 commits into from
Aug 22, 2023
Merged

Webhooks Public API #2790

merged 10 commits into from
Aug 22, 2023

Conversation

mderynck
Copy link
Contributor

@mderynck mderynck commented Aug 14, 2023

What this PR does

  • Add public API for Webhooks CRUD, and GET webhook responses
  • Add insight resource logs for internal and public webhook API calls
  • Change public actions API to wrap Webhooks to maintain compatibility with existing callers

Which issue(s) this PR fixes

#2792
#2793

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@mderynck mderynck self-assigned this Aug 14, 2023
}

assert response.status_code == status.HTTP_201_CREATED
assert response.json() == expected_result


@pytest.mark.django_db
def test_create_custom_action_invalid_data(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was removed since validation is now processed at runtime because URLs can now contain templates.

@mderynck mderynck marked this pull request as ready for review August 18, 2023 17:50
@mderynck mderynck requested a review from a team as a code owner August 18, 2023 17:50
@mderynck mderynck requested a review from a team August 18, 2023 17:50
Copy link
Contributor

@matiasb matiasb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

engine/apps/public_api/serializers/webhooks.py Outdated Show resolved Hide resolved
@mderynck mderynck disabled auto-merge August 22, 2023 20:05
@mderynck mderynck merged commit 7440a83 into dev Aug 22, 2023
20 checks passed
@mderynck mderynck deleted the mderynck/webhooks-public-api branch August 22, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants