Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return API URL as part of status #2791

Merged
merged 10 commits into from
Aug 22, 2023
Merged

Return API URL as part of status #2791

merged 10 commits into from
Aug 22, 2023

Conversation

mderynck
Copy link
Contributor

@mderynck mderynck commented Aug 15, 2023 •
edited
Loading

What this PR does

  • Provide API URL when returning status to inform plugin or mobile app if it should be talking to a different backend in case of migration.
  • Add MobileAppAuthTokenAuthentication to status endpoint so that the app can use it.
  • Split PluginAuthentication (Checks user) and BasePluginAuthentication (Does not check user) and use BasePluginAuthentication in grafana-plugin app when getting status.
  • Removed PluginTokenVerified since it can be handled by BasePluginAuthentication.
  • Removed deprecated endpoints from grafana-plugin app.

Which issue(s) this PR fixes

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@mderynck mderynck added the pr:no public docs Added to a PR that does not require public documentation updates label Aug 15, 2023
@mderynck mderynck marked this pull request as ready for review August 15, 2023 18:13
@mderynck mderynck requested a review from a team August 15, 2023 18:13
@mderynck mderynck self-assigned this Aug 16, 2023
joeyorlando
joeyorlando approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 just some minor questions

engine/apps/grafana_plugin/views/sync.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

engine/apps/mobile_app/auth.py Show resolved Hide resolved
@mderynck mderynck added this pull request to the merge queue Aug 22, 2023
Merged via the queue into dev with commit 0dfa882 Aug 22, 2023
20 checks passed
@mderynck mderynck deleted the mderynck/mobile-app-status branch August 22, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyorlando joeyorlando joeyorlando approved these changes

Assignees

@mderynck mderynck

Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mderynck @joeyorlando