Improve template to handle empty group labels #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskhakov
reviewed
Aug 15, 2023
| {% if severity %} | ||
| {%- set severity_emoji = {"critical": ":rotating_light:", "warning": ":warning:" }[severity] | default(":question:") -%} | ||
| Severity: {{ severity }} {{ severity_emoji }} | ||
| {% endif %} | ||
|
|
||
| {%- set status = payload.status | default("Unknown") %} | ||
| {%- set status = payload.get("status", "Unknown") %} |
There was a problem hiding this comment.
just curious, what is the difference here? I think previous version is more straightforward and clear for non-python developers
There was a problem hiding this comment.
Just aligned it with other .getusages. ( It was used in previous templates also)
iskhakov
reviewed
Aug 15, 2023
| {%- set status_emoji = {"firing": ":fire:", "resolved": ":white_check_mark:"}[status] | default(":warning:") %} | ||
| Status: {{ status }} {{ status_emoji }} (on the source) | ||
| {% if status == "firing" %} | ||
| {% if status == "firing" and payload.numFiring %} |
There was a problem hiding this comment.
should we add check for numResolved?
There was a problem hiding this comment.
I'm checking the numFiring here to not to render empty ':', since alerts from migrated legacy alertmanager have no numFiring field. I'm still thinking how to do it better.
iskhakov
approved these changes
Aug 15, 2023
Konstantinov-Innokentii
added
the
pr:no public docs
joeyorlando
reviewed
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
– Fix error with missing "groupLabels" or "alertname"
– Support rendering alerts from migrated legacy alertmanagers