increase mobile app verification token TTL from 1 minute to 5 minutes #2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyorlando
added
pr:no changelog
pr:no public docs
vadimkerr
approved these changes
Aug 22, 2023
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
…#2859) # What this PR does Trying to connect a mobile app emulator, following the instructions [here](https://github.com/grafana/oncall-mobile-app#getting-started), to a cloud stack is incredibly difficult given the 1 minute token TTL. You need to retrieve the token from the HTTP response in your browser's inspect panel, plug that token into the `make run` command and cross your fingers that the emulator starts up in < 45 seconds before the token expires. This PR increases the verification token TTL from 1 minute to 5 minutes. ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Trying to connect a mobile app emulator, following the instructions here, to a cloud stack is incredibly difficult given the 1 minute token TTL. You need to retrieve the token from the HTTP response in your browser's inspect panel, plug that token into the
make runcommand and cross your fingers that the emulator starts up in < 45 seconds before the token expires.This PR increases the verification token TTL from 1 minute to 5 minutes.
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)