Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate exported final shifts to match the requested period #2924

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

matiasb
Copy link
Contributor

@matiasb matiasb commented Aug 31, 2023

When calculating on-call load, if an involved shift extends outside the requested time span you can get unexpected results. Truncate the returned events times to keep the details for the specified start/end dates.

@matiasb matiasb added the pr:no public docs Added to a PR that does not require public documentation updates label Aug 31, 2023
@matiasb matiasb marked this pull request as ready for review August 31, 2023 02:42
@matiasb matiasb requested a review from a team August 31, 2023 02:42
@matiasb matiasb force-pushed the matiasb/shifts-export-updates branch from 3a936f9 to 4005a74 Compare August 31, 2023 13:28
Copy link
Member

@vadimkerr vadimkerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matiasb matiasb added this pull request to the merge queue Aug 31, 2023
Merged via the queue into dev with commit 6b8c1ac Aug 31, 2023
20 checks passed
@matiasb matiasb deleted the matiasb/shifts-export-updates branch August 31, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants