Improve Slack error handling #3000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadimkerr
added
the
pr:no public docs
vadimkerr
force-pushed
the
vadimkerr/slack-errors
branch
from
a7c9142
to
8723e17
Compare
# Conflicts: # CHANGELOG.md
vadimkerr
commented
Sep 11, 2023
Comment on lines
-55
to
-66
| except SlackAPIException as e: | ||
| if e.response["error"] == "message_not_found": # message deleted from channel | ||
| logger.info(f"Skip updating slack message for alert_group {alert_group.pk} due message_not_found") | ||
| elif e.response["error"] == "is_inactive": # deleted channel error | ||
| logger.info(f"Skip updating slack message for alert_group {alert_group.pk} due to is_inactive") | ||
| elif e.response["error"] == "account_inactive": | ||
| logger.info(f"Skip updating slack message for alert_group {alert_group.pk} due to account_inactive") | ||
| elif e.response["error"] == "channel_not_found": | ||
| logger.info(f"Skip updating slack message for alert_group {alert_group.pk} due to channel_not_found") | ||
| else: | ||
| raise e | ||
| logger.info(f"Finished _update_slack_message for alert_group {alert_group.pk}") |
There was a problem hiding this comment.
Removing logging here as errors are already logged in SlackClient.api_call
| def __init__(self, msg: str, response: SlackResponse): | ||
| super().__init__(msg) | ||
| self.response = response | ||
| class SlackServerErrorRetryHandler(RetryHandler): |
There was a problem hiding this comment.
⬆️ One of the main changes in the PR
| response = super(SlackClientWithErrorHandling, self).api_call(*args, **kwargs) | ||
| except SlackApiError as err: | ||
| response = err.response | ||
| def api_call(self, *args, **kwargs) -> SlackResponse: |
There was a problem hiding this comment.
⬆️ One of the main changes in the PR
| body: str | ||
|
|
||
|
|
||
| class SlackAPIError(Exception): |
There was a problem hiding this comment.
⬆️ One of the main changes in the PR
vadimkerr
commented
Sep 11, 2023
Comment on lines
-133
to
-134
| # Trying same request with access token. It is required due to migration to granular permissions | ||
| # and can be removed after clients reinstall their bots |
There was a problem hiding this comment.
can be removed after clients reinstall their bots
The switch to granular permissions happened a long time ago so I think it's safe to remove this
matiasb
approved these changes
Sep 11, 2023
vadimkerr
force-pushed
the
vadimkerr/slack-errors
branch
from
286d393
to
5b1be85
Compare
joeyorlando
reviewed
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
SlackClientWithErrorHandlingto justSlackClient5xxerrors)Which issue(s) this PR fixes
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)