Fix public actions endpoint to handle empty user field #3053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e other webhooks updates
mderynck
added
the
pr:no public docs
mderynck
changed the title
vadimkerr
approved these changes
Sep 26, 2023
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 3, 2023
# What this PR does Fix update calls made by terraform when user field is empty or not present. Should have been part of: #3053 ## Which issue(s) this PR fixes grafana/terraform-provider-grafana#1025 ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes a regression that was introduced when actions were remapped to new webhooks. Validation in the serializer was making the user field no longer accept blank and None values. This PR makes those values accepted again.
Which issue(s) this PR fixes
grafana/terraform-provider-grafana#1025
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)