Pagination refactoring/cleanup #3205
Conversation
teodosii
added
the
pr:no public docs
| @@ -78,27 +76,29 @@ class Incidents extends React.Component<IncidentsPageProps, IncidentsPageState> | |||
|
|
|||
| const cursor = cursorQuery || undefined; | |||
| const start = !isNaN(startQuery) ? Number(startQuery) : 1; | |||
| const itemsPerPage = !isNaN(perpageQuery) ? Number(perpageQuery) : ITEMS_PER_PAGE; | |||
|
|
|||
| const end = !isNaN(perpageQuery) ? Number(perpageQuery) : undefined; | |||
There was a problem hiding this comment.
This will set it to either the query's values or to 1 and undefined, where the end will be determined when fetching the results
| componentDidMount() { | ||
| const { alertGroupStore } = this.props.store; | ||
|
|
||
| alertGroupStore.updateBulkActions(); |
There was a problem hiding this comment.
These belong in the cDM and not in the constructor.
| <CursorPagination | ||
| current={`${pagination.start}-${pagination.end}`} | ||
| itemsPerPage={alertGroupStore.incidentsItemsPerPage} | ||
| itemsPerPageOptions={[ |
There was a problem hiding this comment.
ideally those options should depend on page_size
There was a problem hiding this comment.
Hmm unfortunately the paging on alert group is slightly different than what we have traditionally in the other places. You kind of need the ends of the pagination 🤔
There was a problem hiding this comment.
Ahh nvm, that can be changed. I thought you were referring to the pagination state
| @@ -294,21 +280,30 @@ export class AlertGroupStore extends BaseStore { | |||
| // @ts-ignore | |||
| this.alerts = new Map<number, Alert>([...this.alerts, ...newAlerts]); | |||
|
|
|||
| this.incidentsItemsPerPage = page_size; | |||
There was a problem hiding this comment.
do we really need to store this in alertgroupstore as a separate field? can we get it as getSearchResult().page_size?
There was a problem hiding this comment.
I guess you're right, let me try it 🤔
There was a problem hiding this comment.
This just doesn't seem to work quite as expected if we only replace it with getSearchResult() because there's no way to trigger the pagination update nested in the state of the component 🤔
# What this PR does - Pagination cleanup so that frontend no longer hardcodes page size - Moved pagination to the filters store instead for all pages that have pagination enabled - Prevent UI triggering polling if window is inactive or if the previous request didn't complete ## Which issue(s) this PR fixes #2931 #2462 ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
What this PR does
Which issue(s) this PR fixes
#2931
#2462
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)