Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jinja2 template helper filter b64decode #3242

Merged
merged 9 commits into from
Nov 6, 2023
Merged

Jinja2 template helper filter b64decode #3242

merged 9 commits into from
Nov 6, 2023

Conversation

jorgeav
Copy link
Contributor

@jorgeav jorgeav commented Nov 1, 2023

What this PR does

Add an additional jinja2 template helper filter to decode base64-encoded strings.

An example of an incoming integration payload that would benefit from this filter is GCP's pubsub message:

https://cloud.google.com/pubsub/docs/reference/rest/v1/PubsubMessage

Which issue(s) this PR fixes

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@jorgeav jorgeav requested a review from a team as a code owner November 1, 2023 22:43
@jorgeav jorgeav requested review from a team November 1, 2023 22:43
@CLAassistant
Copy link

CLAassistant commented Nov 1, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the first contribution @jorgeav 😄 LGTM!

@joeyorlando
Copy link
Contributor

@jorgeav do you mind pushing up a commit to address the linting error? Once that is addressed I will go ahead and merge this.

auto-merge was automatically disabled November 3, 2023 23:27

Head branch was pushed to by a user without write access

@joeyorlando joeyorlando merged commit 80f5818 into grafana:dev Nov 6, 2023
16 of 17 checks passed
brojd pushed a commit that referenced this pull request Sep 18, 2024
# What this PR does
Add an additional jinja2 template helper filter to decode base64-encoded
strings.

An example of an incoming integration payload that would benefit from
this filter is GCP's pubsub message:

https://cloud.google.com/pubsub/docs/reference/rest/v1/PubsubMessage 

## Which issue(s) this PR fixes

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)

---------

Co-authored-by: Jorge Vargas <jorge.vargas@homeprotech.com>
Co-authored-by: Joey Orlando <joey.orlando@grafana.com>
Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants