Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters polishing, remove displaying rotation modal for Terraform/API based schedules #3259

Merged
merged 8 commits into from
Nov 23, 2023

Conversation

maskin25
Copy link
Contributor

@maskin25 maskin25 commented Nov 2, 2023

What this PR does

Filters fixes and polishing, remove displaying rotation modal for Terraform/API bases schedules

Which issue(s) this PR fixes

#1714
https://github.com/grafana/oncall-private/issues/2246
#3183

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@maskin25 maskin25 requested a review from a team November 2, 2023 12:50
@maskin25 maskin25 added the pr:no public docs Added to a PR that does not require public documentation updates label Nov 2, 2023
@maskin25 maskin25 changed the title Filters polishing, remove displaying rotation modal for Terraform/API bases schedules Filters polishing, remove displaying rotation modal for Terraform/API based schedules Nov 2, 2023
@maskin25 maskin25 enabled auto-merge November 23, 2023 09:53
@maskin25 maskin25 added this pull request to the merge queue Nov 23, 2023
Merged via the queue into dev with commit 8645e55 Nov 23, 2023
@maskin25 maskin25 deleted the maxim/1714-filters-fixes branch November 23, 2023 10:00
brojd pushed a commit that referenced this pull request Sep 18, 2024
… based schedules (#3259)

# What this PR does

Filters fixes and polishing, remove displaying rotation modal for
Terraform/API bases schedules

## Which issue(s) this PR fixes

#1714
https://github.com/grafana/oncall-private/issues/2246
#3183

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [ ] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants