Alert group column/label selector #3281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodosii
added
pr:no changelog
pr:no public docs
vadimkerr
reviewed
Nov 24, 2023
maskin25
reviewed
Nov 24, 2023
| @@ -170,7 +170,7 @@ const TeamModal = ({ teamId, onHide }: TeamModalProps) => { | |||
| { label: 'Team members and admins', value: '0' }, | |||
| ]} | |||
| value={shareResourceToAll} | |||
| onChange={setShareResourceToAll} | |||
| onChange={setShareResourceToAll as (res: string) => void} | |||
There was a problem hiding this comment.
can we don't use type casting here?
There was a problem hiding this comment.
the setter is a React.Dispatch, while the onChange expects something else
maskin25
reviewed
Nov 24, 2023
Konstantinov-Innokentii
approved these changes
Nov 29, 2023
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
# What this PR does Adds new functionality to enable which columns should show on the alert group page  --------- Co-authored-by: Julia <ferril.darkdiver@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds new functionality to enable which columns should show on the alert group page