Direct paging integrations table #3290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internal API endpoint
3 tasks
teodosii
reviewed
Nov 9, 2023
| // // Create 1 direct paging integration and 2 other connections | ||
| const WEBHOOK_INTEGRATION_NAME = 'Webhook-1'; | ||
| const ALERTMANAGER_INTEGRATION_NAME = 'Alertmanager-1'; | ||
| const DIRECT_PAGING_INTEGRATION_NAME = 'Direct paging-1'; |
There was a problem hiding this comment.
Won't this fail if run multiple times? Shouldn't this use a randomizer?
There was a problem hiding this comment.
Yep, good idea, that will make development of e2e easier, let me do that :) Good catch
There was a problem hiding this comment.
@teodosii it's done now. For Direct Paging item I did that a bit differently because there must be no duplicates of Direct Paging integration assigned to a single team. So I'm checking in test if one has already been created and I'm making sure that we don't try to create a duplicate. At this point its name doesn't matter
brojd
added
the
pr:no public docs
teodosii
approved these changes
Nov 9, 2023
brojd
added a commit
that referenced
this pull request
Sep 18, 2024
# What this PR does Closes #3119 Closes grafana/oncall-private#2061 ## Which issue(s) this PR fixes ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) --------- Co-authored-by: Dominik <dominik.broj@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Closes #3119
Closes https://github.com/grafana/oncall-private/issues/2061
Which issue(s) this PR fixes
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)