fix(3093) Return timezone field of the user via public API #3311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyorlando
reviewed
Nov 9, 2023
There was a problem hiding this comment.
hi @ravishankar15! thank you for your contribution 😄
Just two small asks and then I will go ahead and approve/merge this in:
- do you mind adding a small note to the
CHANGELOG.mdabout this? - can you update the public API docs here to include this new field in the response schemas?
Again, thanks!
ravishankar15
force-pushed
the
3093-return-timezone-public-api
branch
from
ae9e13b to
2257a95
Compare
ravishankar15
force-pushed
the
3093-return-timezone-public-api
branch
from
2257a95 to
23bc32c
Compare
Modified changelog commit message
ravishankar15
force-pushed
the
3093-return-timezone-public-api
branch
from
23bc32c to
d38476a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Return the
timezonefield for the users GET API callWhich issue(s) this PR fixes
Closes #3093
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)