-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schedule quality backend #338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Added a few comments/suggestions, feel free to ignore them if they don't make sense :-)
@vadimkerr should this PR be merged? (just doing a check on PRs that have been open for a few months 😄 ) |
This PR needs some front end changes as well, @teodosii could you please take a look at this? |
It's on my list, I need some more time to finish current work and then I can get on this one. |
# Conflicts: # engine/apps/api/views/schedule.py
Some additional backend chages are needed to support this design, so converting back to draft PR. |
Merging the backend part for now, @teodosii let's have a separate PR for the frontend. |
This PR adds an endpoint returning a schedule quality score, overloaded users and comments on the existing issues (e.g. balance issues or gaps).
Limitations
Usage
GET /api/internal/v1/schedules/<pk>/quality?date=<TOMORROW_DATE>
Note that
date
should be tomorrow date, because we can only be sure about changing tomorrow's shifts (some of the shifts for current day could be "deleted" but still show up in the UI).Example response
Issue: #118