generate types, create http client and add exemplary usage #3384
Conversation
| @@ -41,6 +43,11 @@ export interface GroupedAlert { | |||
| render_for_web: RenderForWeb; | |||
| } | |||
|
|
|||
| export type AlertGroup = components['schemas']['AlertGroup'] & { | |||
| loading?: boolean; | |||
There was a problem hiding this comment.
just for my own curiosity, where is this loading attribute used? Based on the name I'm guessing it's for... some loading state indicator? If so, could that state be managed external from the response objects we get back from the API? (would get rid of the need to have this type if I understand correctly)
There was a problem hiding this comment.
You're right and yes, our plan on the frontend is to move every loading state like that to a separate dedicated store. So that they are completely separated from models/domains themselves
brojd
added
pr:no changelog
pr:no public docs
|
|
||
| | :warning: WARNING | | ||
| | :------------------------------------------------------------------------------------------ | | ||
| | Transition to this approach is [in progress](https://github.com/grafana/oncall/issues/3338) | |
.pre-commit-config.yaml
Outdated
There was a problem hiding this comment.
nit it seems most of our .yaml files use double-quotes. We might want to consider configuring the quoted-strings rule to make things consistent
There was a problem hiding this comment.
I switched to double quotes in this exact file. But across the codebase we have a mix now so yes, maybe in a separate PR we could change everything to double quotes and add a rule to yamllint
|
Looks very good 👍 |
# What this PR does #3330 - add a script that generates TS type definitions based on OnCall API OpenAPI schemas - support adding custom properties on the frontend if needed - add simple example of usage (for `'/labels/keys/'` endpoint) ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
What this PR does
#3330
'/labels/keys/'endpoint)Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)