Mobile app proxy gateway #3449
Merged
Mobile app proxy gateway #3449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyorlando
added
the
pr:no public docs
joeyorlando
commented
Nov 28, 2023
| if settings.MOBILE_APP_GATEWAY_ENABLED: | ||
| urlpatterns += [ | ||
| re_path( | ||
| r"^gateway/(?P<downstream_backend>\w*)/(?P<downstream_path>.*)$", |
There was a problem hiding this comment.
basically this would proxy the following request:
GET /mobile_app/v1/gateway/incident/test/123/someotherthing/456
into:
downstream_backend = "incident"
downstream_path = "test/123/someotherthing/456"| @classmethod | ||
| def _get_downstream_url(cls, organization: "Organization", downstream_backend: str, downstream_path: str) -> str: | ||
| downstream_url = { | ||
| cls.SupportedDownstreamBackends.INCIDENT: organization.grafana_incident_backend_url, |
There was a problem hiding this comment.
in the future, if we want to add a new proxied backend, we simply need to add a mapping here from the URLConf's downstream_backend to the downstream service's root URL
Comment on lines
+190
to
+195
| """ | ||
| See the default `APIView.dispatch` for more info. Basically this just routes all requests for | ||
| ALL HTTP verbs to the `MobileAppGatewayView._proxy_request` method. | ||
| """ | ||
| for method in APIView.http_method_names: | ||
| setattr(MobileAppGatewayView, method.lower(), MobileAppGatewayView._proxy_request) |
There was a problem hiding this comment.
"hackier" way to support proxying all HTTP verbs
iskhakov
reviewed
Nov 29, 2023
iskhakov
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Closes https://github.com/grafana/oncall-private/issues/2324
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)