Don't update alert group metrics when deleting an alert group #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deleting an alert group
joeyorlando
added
the
pr:no public docs
joeyorlando
commented
Dec 11, 2023
Comment on lines
1220
to
-1226
| self.hard_delete() | ||
| # Update alert group state metric cache | ||
| self._update_metrics(organization_id=user.organization_id, previous_state=initial_state, state=None) |
There was a problem hiding this comment.
an alternative here could be to call self._update_metrics() before calling self.hard_delete()
There was a problem hiding this comment.
I don't think it makes sense to call it before, since it updates metrics async and we don't protect ourself of error it should fix.
I'd propose either call it sync here (but we change it to async everywhere by purpose) or expend parameters we pass to _update_metrics to allow it to update metrics anyway.
For now I think it's ok to remove metrics update from here, since we recalculate all metrics once a day
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes
Fixes https://github.com/grafana/oncall-private/issues/2376
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)