Fix message is too big exception for mobile push notification
#3556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ferril
added
the
pr:no public docs
joeyorlando
approved these changes
Dec 12, 2023
Comment on lines
14
to
18
| print(f"ALERTS COUNT: {alert_group.alerts.count}") # TODO: debugging test. remove after debugging | ||
| alert = alert_group.alerts.first() | ||
| print(f"ALERT TITLE: {alert.title}, DATA: {alert.raw_request_data}") # TODO: debugging test. remove after debugging | ||
| templated_alert = AlertMobileAppTemplater(alert).render() | ||
| print(f"TEMPLATED ALERT: {templated_alert}") # TODO: debugging test. remove after debugging |
There was a problem hiding this comment.
remove print statements
There was a problem hiding this comment.
👍 I'm debugging failing tests, that work locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds limit for alert title length in mobile app push notifications
Which issue(s) this PR fixes
https://github.com/grafana/oncall-private/issues/2375
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)