Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(3564) Support PATCH Method In Outgoing webhook #3580

Merged
merged 6 commits into from
Dec 20, 2023

Conversation

ravishankar15
Copy link
Contributor

@ravishankar15 ravishankar15 commented Dec 18, 2023

What this PR does

Adds PATCH method Support for outgoing webhook

Which issue(s) this PR fixes

Fixes #3564

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@ravishankar15 ravishankar15 requested a review from a team December 18, 2023 12:31
Copy link
Contributor

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi there @ravishankar15 👋 thank you for the contribution. LGTM!

@joeyorlando joeyorlando added the pr:no public docs Added to a PR that does not require public documentation updates label Dec 20, 2023
@joeyorlando
Copy link
Contributor

@ravishankar15 once you address the linting errors I will go ahead and get this merged in!

@joeyorlando joeyorlando merged commit bcbca9d into grafana:dev Dec 20, 2023
17 of 18 checks passed
@ToonTijtgat2
Copy link

Hi Guys, thanks a lot for picking this up.
The fix would be great, since the commit is merged to grafana:dev but there is no new version created, I was wondering if there would be a time estimation on when we could use this nice fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to create outgoing webhook w/ PATCH HTTP Method via the UI
3 participants