Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add supported SMS/voice countries to docs #5219

Merged
merged 6 commits into from
Nov 1, 2024
Merged

docs: add supported SMS/voice countries to docs #5219

merged 6 commits into from
Nov 1, 2024

Conversation

joeyorlando
Copy link
Contributor

No description provided.

@joeyorlando joeyorlando added the release:ignore PR will not be added to release notes label Oct 29, 2024
@joeyorlando joeyorlando requested a review from a team as a code owner October 29, 2024 21:22
@joeyorlando joeyorlando requested a review from a team October 29, 2024 21:22
alyssawada
alyssawada approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@alyssawada alyssawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple small edits but otherwise, LGTM and thanks for adding this!

docs/sources/manage/notify/phone-calls-sms/index.md Outdated Show resolved Hide resolved
docs/sources/manage/notify/phone-calls-sms/index.md Outdated Show resolved Hide resolved
docs/sources/manage/notify/phone-calls-sms/index.md Outdated Show resolved Hide resolved
joeyorlando and others added 2 commits November 1, 2024 05:50
@joeyorlando @alyssawada
Apply suggestions from code review
a166068 
Co-authored-by: Alyssa Wada <101596687+alyssawada@users.noreply.github.com>
@joeyorlando
Merge branch 'dev' into jorlando/add-supported-twilio-countries-to-docs
af5cc10
@joeyorlando joeyorlando enabled auto-merge November 1, 2024 04:50
@joeyorlando joeyorlando disabled auto-merge November 1, 2024 04:59
@joeyorlando joeyorlando mentioned this pull request Nov 1, 2024
Closed
3 tasks
@joeyorlando joeyorlando added this pull request to the merge queue Nov 1, 2024
@joeyorlando
Merge branch 'jorlando/add-supported-twilio-countries-to-docs' of git…
d04e499 
…hub.com:grafana/oncall into jorlando/add-supported-twilio-countries-to-docs
@joeyorlando joeyorlando removed this pull request from the merge queue due to a manual request Nov 1, 2024
@joeyorlando joeyorlando enabled auto-merge November 1, 2024 05:07
@joeyorlando joeyorlando added this pull request to the merge queue Nov 1, 2024
Merged via the queue into dev with commit 23aa7eb Nov 1, 2024
24 checks passed
@joeyorlando joeyorlando deleted the jorlando/add-supported-twilio-countries-to-docs branch November 1, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssawada alyssawada alyssawada approved these changes

Assignees
No one assigned
Labels
release:ignore PR will not be added to release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeyorlando @alyssawada