Fix issue with DST starting/ending causing overlaps/gaps #5266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zackman0010
temporarily deployed
to
github-pages
GitHub Actions
Inactive
zackman0010
temporarily deployed
to
github-pages
GitHub Actions
Inactive
zackman0010
temporarily deployed
to
github-pages
GitHub Actions
Inactive
By looping through each event and using normalize, the tzinfo might change DST status. We can check for this change in DST status to adjust the end date either forward or backward, depending if DST stopped or started.
Fixing formatting issues as shown by failing lint test on MR
matiasb
force-pushed
the
dst-fix-no-dep-update
branch
from
ac7e621
to
db96024
Compare
matiasb
added
pr:no public docs
|
Thanks @zackman0010 for the contribution (reporting the bug, and the fix)! |
matiasb
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This older version of recurring_ical_events does not call the pytz .normalize() function, which can cause some invalid datetime objects to return when a DST swap happens. For example: Nov 3, 2024 9:00 AM CDT instead of the correct 8:00 AM CST). By calling tz.normalize on the end date and checking if the time zone information changed, we can detect when DST starts/stops and adjust the end date accordingly.
Which issue(s) this PR closes
Closes #5247
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.