chore: patch recent migration files that drop db columns #5277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyorlando
added
pr:no public docs
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
commented
Nov 20, 2024
Comment on lines
-15
to
-18
| migrations.RemoveField( | ||
| model_name='channelfilter', | ||
| name='_slack_channel_id', | ||
| ), |
There was a problem hiding this comment.
moved to engine/apps/alerts/migrations/0067_remove_channelfilter__slack_channel_id_state.py
Comment on lines
-19
to
-22
| migrations.RemoveField( | ||
| model_name='resolutionnoteslackmessage', | ||
| name='_slack_channel_id', | ||
| ), |
There was a problem hiding this comment.
moved to engine/apps/alerts/migrations/0068_remove_resolutionnoteslackmessage__slack_channel_id_state.py
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
…afana/oncall into jorlando/patch-recent-migration-files
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
commented
Nov 20, 2024
There was a problem hiding this comment.
example of when this passes:
Checking engine/apps/alerts/migrations/0066_remove_channelfilter__slack_channel_id_and_more.py for migrations.RemoveField...
✅ No RemoveField found in engine/apps/alerts/migrations/0066_remove_channelfilter__slack_channel_id_and_more.py
Checking engine/apps/alerts/migrations/0067_remove_channelfilter__slack_channel_id_state.py for migrations.RemoveField...
✅ No RemoveField found in engine/apps/alerts/migrations/0067_remove_channelfilter__slack_channel_id_state.py
Checking engine/apps/alerts/migrations/0068_remove_resolutionnoteslackmessage__slack_channel_id_state.py for migrations.RemoveField...
✅ No RemoveField found in engine/apps/alerts/migrations/0068_remove_resolutionnoteslackmessage__slack_channel_id_state.py
Checking engine/apps/schedules/migrations/0020_remove_oncallschedule_channel_state.py for migrations.RemoveField...
✅ No RemoveField found in engine/apps/schedules/migrations/0020_remove_oncallschedule_channel_state.py
Checking engine/apps/user_management/migrations/0028_remove_organization_general_log_channel_id_state.py for migrations.RemoveField...
✅ No RemoveField found in engine/apps/user_management/migrations/0028_remove_organization_general_log_channel_id_state.pyexample of when it catches a failure:
Checking engine/apps/alerts/migrations/0066_remove_channelfilter__slack_channel_id_and_more.py for migrations.RemoveField...
✅ No RemoveField found in engine/apps/alerts/migrations/0066_remove_channelfilter__slack_channel_id_and_more.py
Checking engine/apps/alerts/migrations/0067_remove_channelfilter__slack_channel_id_state.py for migrations.RemoveField...
✅ No RemoveField found in engine/apps/alerts/migrations/0067_remove_channelfilter__slack_channel_id_state.py
Checking engine/apps/alerts/migrations/0068_remove_resolutionnoteslackmessage__slack_channel_id_state.py for migrations.RemoveField...
✅ No RemoveField found in engine/apps/alerts/migrations/0068_remove_resolutionnoteslackmessage__slack_channel_id_state.py
Checking engine/apps/schedules/migrations/0020_remove_oncallschedule_channel_state.py for migrations.RemoveField...
✅ No RemoveField found in engine/apps/schedules/migrations/0020_remove_oncallschedule_channel_state.py
Checking engine/apps/user_management/migrations/0028_remove_organization_general_log_channel_id_state.py for migrations.RemoveField...
✅ No RemoveField found in engine/apps/user_management/migrations/0028_remove_organization_general_log_channel_id_state.py
Checking engine/apps/user_management/migrations/0029_joey_test.py for migrations.RemoveField...
❌ Error: Found migrations.RemoveField in engine/apps/user_management/migrations/0029_joey_test.py
❌ Error: Found migrations.RemoveField in one or more migration files. Please check out our documentation at https://github.com/grafana/oncall/tree/dev/dev#removing-a-nullable-field-from-a-model on how to properly drop columns.
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Failure
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Failure
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Failure
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
3 tasks
joeyorlando
added a commit
that referenced
this pull request
Nov 21, 2024
# What this PR does Second, and final part of, #5277 ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] Added the relevant release notes label (see labels prefixed w/ `release:`). These labels dictate how your PR will show up in the autogenerated release notes.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
(as documented here, I have the four additional migration files (which actually do the
DROP COLUMNs in the db) saved locally, and will include these in a separate PR/release)Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.