Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping workflow version to use node 16 instead of deprecated node 12 #143

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

tolzhabayev
Copy link
Collaborator

What this PR does / why we need it:

Removes this deprecation warning, which you can see here

SCR-20221114-f44

@tolzhabayev tolzhabayev requested review from a team and academo and removed request for a team November 14, 2022 09:53
@tolzhabayev tolzhabayev self-assigned this Nov 14, 2022
@tolzhabayev tolzhabayev requested review from jackw and leventebalogh and removed request for academo November 14, 2022 09:53
@tolzhabayev tolzhabayev added create-plugin related to the create-plugin tool and removed create-plugin related to the create-plugin tool labels Nov 14, 2022
@tolzhabayev
Copy link
Collaborator Author

🤔 what labels are correct in this case?

@tolzhabayev tolzhabayev changed the title Bumping workflow version to use node 16 instead of deprecated node 14 Bumping workflow version to use node 16 instead of deprecated node 12 Nov 14, 2022
Copy link
Collaborator

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@leventebalogh
Copy link
Collaborator

I guess we should have a chore label or something similar? 🤔

@jackw jackw added the chore Other changes that don't modify src or test files label Nov 14, 2022
@jackw
Copy link
Collaborator

jackw commented Nov 14, 2022

🤔 what labels are correct in this case?

In regard to a release label? We shouldn't need any labels. It'll be ignored as it doesn't affect any of the packages.

I guess we should have a chore label or something similar? 🤔

Have added one and attached it to this PR!

Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@tolzhabayev tolzhabayev merged commit d264eca into main Nov 14, 2022
@tolzhabayev tolzhabayev deleted the chore/bump-nodeversion branch November 14, 2022 10:45
@grafanabot
Copy link
Contributor

🚀 PR was released in @grafana/create-plugin@0.5.1 🚀

@grafanabot grafanabot added the released This issue/pull request has been released. label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Other changes that don't modify src or test files released This issue/pull request has been released.
Projects
Development

Successfully merging this pull request may close these issues.

4 participants