Create-Plugin: Backend template: Switch from Info to Debug level #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xnyo
added
enhancement
wbrowne
reviewed
Nov 15, 2022
| log.DefaultLogger.Info("QueryData called", "request", req) | ||
| // when logging at a non-Debug level, make sure you don't include sensitive information in the message | ||
| // (like the *backend.QueryDataRequest) | ||
| log.DefaultLogger.Debug("QueryData called", "request", req) |
There was a problem hiding this comment.
In this case I'd remove the *backend.QueryDataRequest param completely just in case people don't think to read the comment, don't understand it or just blindly delete it 🙈
There was a problem hiding this comment.
Like this?
Suggested change
| log.DefaultLogger.Debug("QueryData called", "request", req) | |
| log.DefaultLogger.Debug("QueryData called") |
There was a problem hiding this comment.
Yeah I think that should be fine! You could also add something like:
log.DefaultLogger.Debug("QueryData called", "numQueries", len(req.Queries))to demonstrate how to pass key values to the log. Totally up to you 😄
There was a problem hiding this comment.
Good point! I think demonstrating how to pass key/value to the log is valuable 👍 👍
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
InfotoDebugInfolevelWhich issue(s) this PR fixes:
Fixes #140
Special notes for your reviewer: