Create Plugin: Remove links pointing to deprecated starter templates #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackw
added
bug
create-plugin
jackw
commented
Nov 29, 2022
| @@ -257,7 +257,7 @@ function printSuccessMessage(answers: CliArgs) { | |||
| ]; | |||
|
|
|||
| return ` | |||
| Congratulations on scaffolding a Grafana ${answers.pluginName} plugin! 🚀 | |||
| Congratulations on scaffolding a Grafana ${answers.pluginType} plugin! 🚀 | |||
There was a problem hiding this comment.
Spotted this mistake I made in previous PR whilst testing.
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Generated links in plugin.json incorrectly point to the deprecated starter templates. This PR removes them.
Which issue(s) this PR fixes:
Fixes #129
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/create-plugin@0.7.1-canary.162.e431ddf.0 # or yarn add @grafana/create-plugin@0.7.1-canary.162.e431ddf.0