Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixin: Change from Phlare to Pyroscope #2342

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

nlamirault
Copy link
Contributor

@nlamirault nlamirault commented Aug 31, 2023

Before this fix:

❯ mixtool generate all mixin.libsonnet
2023/08/31 10:02:14 RUNTIME ERROR: couldn't open import "dashboards/phlare-writes.libsonnet": no match locally or in the Jsonnet library paths
        dashboards.libsonnet:2:2-45     $
        mixin.libsonnet:2:2-31  $
        2:16-40 thunk <mixin> from <$>
        4:21-26 thunk from <$>
        <std>:1548:21-22        thunk from <function <anonymous>>
        <std>:1548:5-32 function <anonymous>
        4:4-47  $
        During evaluation

After:

❯ mixtool generate all mixin.libsonnet
❯ ls dashboards_out
pyroscope-reads.json    pyroscope-writes.json

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@nlamirault nlamirault requested a review from a team as a code owner August 31, 2023 08:03
@CLAassistant
Copy link

CLAassistant commented Aug 31, 2023

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 9df0222 into grafana:main Aug 31, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants