-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create "Ingest and analyze profile data" section in docs #2828
Conversation
--profile-type=memory:inuse_space:bytes:space:bytes | ||
--query='{service_name="my_application_name"}' \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we explicitly write out the defaults so that people copy-pasting are aware of how and what format to change the time frame for something like this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also is this really "merging" or just querying?
for example if I query data from 12:00 to 12:45 and I merge data from 12:00-12:45 isn't that the same thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we explicitly write out the defaults so that people copy-pasting are aware of how and what format to change the time frame for something like this ?
Done!
also is this really "merging" or just querying?
for example if I query data from 12:00 to 12:45 and I merge data from 12:00-12:45 isn't that the same thing?
We call it "merge" throughout the codebase because we are (potentially) merging data from multiple profiles into one. I agree that it is a confusing word, merge is often used for mutating operations (e.g., git merge
).
I don't think we can call it just query
here since we have two subcommands (merge
and series
) but we could call it query profile
potentially (with the risk of confusion about whether it returns data from one or more profiles). I'll leave it as it is for now though to avoid a breaking change at this time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some minor updates to this content--mostly just fixing headings and some formatting. Let's get this approved so we can work on the introductory material. Some o f the content on Analyze profiles will move to the introduction content.
Changes: