Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration testing of microservices/replication for label queries #3130

Conversation

simonswine
Copy link
Contributor

@simonswine simonswine commented Mar 22, 2024

I am currently trying to understand some behaviour while running with an unhealthy ingester/store-gateway each.

For this purpose I've create this testing helper that can spin up multiple microservices locally.

To test the integration of the microservices in a similar to is actually
run in the scalable/high availability setup.

After the cluster is fully started, it pushes profiles for a number of
services and then queries the series, label names and label values. It
then stops one instance each to ensure it is still queryable wihtout
data loss.
@simonswine simonswine force-pushed the 20240322_improve-integration-test-with-microservices branch from b7cbb34 to 9f35982 Compare March 27, 2024 18:31
@simonswine simonswine changed the title [WIP] Allow integration testing of microservices/replication Add integration testing of microservices/replication for label queries Mar 27, 2024
@simonswine
Copy link
Contributor Author

I think the current state contains something that is already mergable, I would like to see how stable the test is and then potentially extend the coverage.

@simonswine simonswine marked this pull request as ready for review March 28, 2024 19:24
@simonswine simonswine requested a review from a team as a code owner March 28, 2024 19:24
Copy link
Collaborator

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this! This will definitely make development and testing easier, and will improve test coverage in general 👍🏻 I'll add cases for select stacktraces and select pprof queries soon. Also, I'll see if testify/suite can be useful here

@simonswine simonswine merged commit dd7856c into grafana:main Apr 2, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants