-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HPA Support for all Pyroscope components #3157
Conversation
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
You need to run |
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Updated PR, now it will mostly pass on all checks, A Quick question should I add |
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
@weastel I think that would be a nice way to test it yes please! |
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
@simonswine As discussed added tests for new HPA based configuration, Can you please review this addition? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@weastel thank you for your work on this ❤️ |
As Mentioned in #2445 Added Support for HPA for all pyroscope components similar to loki based schema.
Schema for adding HPA to any component is as follows:
For eg:
results into: