Use dynamic labels for nodejs examples and docs #3309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
changed the title
simonswine
changed the title
simonswine
force-pushed
the
20240522_update-nodejs-docs
branch
from
aaf95d9
to
9db192f
Compare
|
@knylander-grafana I am moving the outdated config from the SDK repo readme into the proper docs. I would appreciate you taking a look at this. grafana/pyroscope-nodejs#75 removed the in areas incorrect README. |
This updates the nodejs examples and docs to align with the v0.3.11 release. It also adds nodejs to the updater script Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
simonswine
force-pushed
the
20240522_update-nodejs-docs
branch
from
3fde128
to
556f73f
Compare
simonswine
changed the title
aleks-p
approved these changes
May 29, 2024
aleks-p
reviewed
May 29, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the nodejs examples and docs for the latest version v0.3.11.
It also adds nodejs to the updater script, to ensure our examples stay up to date.