Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve validation for Ad Hoc profile uploads #3324

Merged
merged 1 commit into from
May 29, 2024
Merged

Improve validation for Ad Hoc profile uploads #3324

merged 1 commit into from
May 29, 2024

Conversation

aleks-p
Copy link
Contributor

@aleks-p aleks-p commented May 29, 2024

Tries to address #3320. Without the actual input, it is only a guess that this is what caused it.

@aleks-p aleks-p requested a review from a team as a code owner May 29, 2024 10:55
simonswine
simonswine approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Input validation ftw.

Thanks for fixing this 🤞

@aleks-p aleks-p merged commit ed202fa into main May 29, 2024
16 checks passed
@aleks-p aleks-p deleted the fix-ad-hoc-panic branch May 29, 2024 15:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonswine simonswine simonswine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleks-p @simonswine