docs: Add notice about heap profiling #3494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was something I noticed we are missing.
simonswine
force-pushed
the
20240816_dotnet-docs-heap
branch
from
b8f8a12
to
59481ff
Compare
simonswine
added
type/docs
|
This PR must be merged before a backport PR will be created. |
1 similar comment
|
This PR must be merged before a backport PR will be created. |
korniltsev
approved these changes
Aug 16, 2024
|
Looks like it was added after the others? |
knylander-grafana
approved these changes
Aug 16, 2024
Are there any caveats that go along with this option? |
We are not fully sure, at least it requiers .Net 7.0+. Let's document the flag it will be still default off. |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
This was something I noticed we are missing. (cherry picked from commit c40ee84)
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3494-to-release/v1.7 origin/release/v1.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x c40ee842d6a0a11666ad415bfc3d70c2db957b07When the conflicts are resolved, stage and commit the changes: If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-3494-to-release/v1.7
# Create the PR body template
PR_BODY=$(gh pr view 3494 --json body --template 'Backport c40ee842d6a0a11666ad415bfc3d70c2db957b07 from #3494{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title '[release/v1.7] docs: Add notice about heap profiling' --body-file - --label 'type/docs' --label 'backport' --base release/v1.7 --milestone release/v1.7 --webOr, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-3494-to-release/v1.7
# Create a pull request where the `base` branch is `release/v1.7` and the `compare`/`head` branch is `backport-3494-to-release/v1.7`.
# Remove the local backport branch
git switch main
git branch -D backport-3494-to-release/v1.7 |
simonswine
added a commit
that referenced
this pull request
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a profiler in the dotnet sdk I noticed we are missing.