Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename GitSession to pyroscope_git_session #3542

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

alsoba13
Copy link
Contributor

@alsoba13 alsoba13 commented Sep 5, 2024

This is the third step of the migration from GitSession to pyroscope_git_session cookie name.

More details on the migration here: https://github.com/grafana/pyroscope-squad/issues/171#issuecomment-2328555748

This PR should be merged after the frontend:

This change should be safe as soon as you are using a frontend version that accepts both GitSession and pyroscope_git_session

Copy link
Contributor

@bryanhuhta bryanhuhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alsoba13 alsoba13 marked this pull request as ready for review September 18, 2024 09:17
@alsoba13 alsoba13 requested a review from a team as a code owner September 18, 2024 09:17
Copy link
Contributor

@marcsanmi marcsanmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alsoba13 alsoba13 merged commit 40c5cc5 into main Sep 20, 2024
18 checks passed
@alsoba13 alsoba13 deleted the chore/rename-GitSession-to-pyroscope_git_session branch September 20, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants