feat(v2): extend period for truncation, do not truncate all blocks #3548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleks-p
force-pushed
the
v2/improve-block-truncation
branch
from
e26a5c4
to
ae91f42
Compare
korniltsev
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in the v2 arch we delete all blocks older than 12 hours. This was added when compaction wasn't fully in place, as a way to prevent ever increasing resource usage. Compaction is now in place, but without the metastore index and its time-based block partitioning we can still accumulate many blocks over a longer period. Aside from high resource usage, this can make the read path slower since we currently scan all blocks to create query plans.
This PR makes truncation less aggressive. Alternatively we could remove truncation altogether but I think it makes more sense to do that once we have the metastore index.