Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: migrate tests to ginkgo v2 #845

Merged
merged 4 commits into from
Feb 21, 2022

Conversation

dhanusaputra
Copy link
Contributor

close #824

@CLAassistant
Copy link

CLAassistant commented Feb 15, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #845 (5a8b80c) into main (1ab101c) will decrease coverage by 3.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #845      +/-   ##
==========================================
- Coverage   70.44%   67.45%   -2.99%     
==========================================
  Files          71       81      +10     
  Lines        2523     2838     +315     
  Branches      458      545      +87     
==========================================
+ Hits         1777     1914     +137     
- Misses        718      896     +178     
  Partials       28       28              
Impacted Files Coverage Δ
...omponents/FlameGraph/FlamegraphRenderer.module.css 61.54% <0.00%> (ø)
.../FlameGraph/FlameGraphComponent/styles.module.scss 61.54% <0.00%> (ø)
webapp/lib/index.tsx 100.00% <0.00%> (ø)
...pp/javascript/components/ProfilerTable.module.scss 53.85% <0.00%> (ø)
webapp/images/logo-v3-small.svg 100.00% <0.00%> (ø)
...FlameGraph/FlameGraphComponent/Tooltip.module.scss 61.54% <0.00%> (ø)
webapp/javascript/models/flamebearer.ts 36.37% <0.00%> (ø)
...cript/components/FlameGraph/FlameGraphRenderer.jsx 45.54% <0.00%> (ø)
webapp/javascript/components/ProfilerTable.jsx 5.95% <0.00%> (ø)
...ebapp/javascript/components/ExportData.module.scss 61.54% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ab101c...5a8b80c. Read the comment docs.

@abeaumont
Copy link
Contributor

Thanks for your contribution @dhanusaputra! It seem tests are failing though, as some of them have not been migrated.

. "github.com/onsi/gomega"
"github.com/tommy351/goldga"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove this because this package still use v1, will lead to panic
onsi/ginkgo#875

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not great, but not a big deal in my opinion. What do you think @eh-am ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhanusaputra Can you try this fork I just created? https://github.com/pyroscope-io/goldga I migrated goldga library to use ginkgo v2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for help
looks ok

@petethepig petethepig changed the title Migrate tests to ginkgo v2 ci: migrate tests to ginkgo v2 Feb 16, 2022
@petethepig petethepig merged commit ac1fdd2 into grafana:main Feb 21, 2022
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
* Fixes iterator At value re-used

* make fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate tests to ginkgo v2
4 participants