Skip to content

Commit

Permalink
Remove max check labels verification
Browse files Browse the repository at this point in the history
This should now be done in the API taking into account the particular
tenant limits.
  • Loading branch information
ka3de committed Mar 6, 2024
1 parent 1c09461 commit 5e12d74
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions pkg/pb/synthetic_monitoring/checks_extra.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ var (
ErrInvalidCheckFrequency = errors.New("invalid check frequency")
ErrInvalidCheckTimeout = errors.New("invalid check timeout")
ErrInvalidCheckLabelName = errors.New("invalid check label name")
ErrTooManyCheckLabels = errors.New("too many check labels")
ErrInvalidCheckLabelValue = errors.New("invalid check label value")
ErrInvalidLabelName = errors.New("invalid label name")
ErrInvalidLabelValue = errors.New("invalid label value")
Expand Down Expand Up @@ -130,7 +129,6 @@ const (
const (
MaxMetricLabels = 20 // Prometheus allows for 32 labels, but limit to 20.
MaxLogLabels = 15 // Loki allows a maximum of 15 labels.
MaxCheckLabels = 10 // Allow 10 user labels for checks,
MaxProbeLabels = 3 // 3 for probes, leaving 7 for internal use.
maxValidLabelValueLength = 2048 // This is the actual max label value length.
MaxLabelValueLength = 128 // Keep this number low so that the UI remains usable.
Expand Down Expand Up @@ -406,10 +404,6 @@ func (c Check) validateTimeout() error {
}

func validateLabels(labels []Label) error {
if len(labels) > MaxCheckLabels {
return ErrTooManyCheckLabels
}

seenLabels := make(map[string]struct{})

for _, label := range labels {
Expand Down

0 comments on commit 5e12d74

Please sign in to comment.