Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use blackbox_exporter with probe_dns_duration_seconds #54

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

mem
Copy link
Contributor

@mem mem commented Jul 9, 2020

The forked version of blackbox_exporter exposes a metric called
"probe_dns_duration_seconds", which is the time it takes for the DNS
check to run, from connection to query and getting results back.

Currently SM is relying on probe_dns_lookup_time_seconds, which is the
wrong metric for this check, as that is reporting the time it takes to
resolve the target, which is the DNS server. Since we normally pass
an IP address as the target, that resolution time is very low
(microseconds).

The change in blackbox_exporter is in this PR:

prometheus/blackbox_exporter#662

Signed-off-by: Marcelo E. Magallon marcelo.magallon@grafana.com

mem added a commit to grafana/synthetic-monitoring-app that referenced this pull request Jul 9, 2020
This PR:

grafana/synthetic-monitoring-agent#54

uses a forked version of blackbox_exporter that exposes a metric called
"probe_dns_duration_seconds", which is the time it takes for DNS check
to complete from connection to getting back the RR from the DNS server.

Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
mem added a commit to grafana/synthetic-monitoring-app that referenced this pull request Jul 9, 2020
This PR:

grafana/synthetic-monitoring-agent#54

uses a forked version of blackbox_exporter that exposes a metric called
"probe_dns_duration_seconds", which is the time it takes for DNS check
to complete from connection to getting back the RR from the DNS server.

Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
@woodsaj
Copy link
Member

woodsaj commented Jul 13, 2020

Given this change was merged upstream, looks like we should just vendor in github.com/prometheus/blackbox_exporter@55c667ab4ce5bdd81ebf8b843851222aa1f7fab3 (current master)

The forked version of blackbox_exporter exposes a metric called
"probe_dns_duration_seconds", which is the time it takes for the DNS
check to run, from connection to query and getting results back.

Currently SM is relying on probe_dns_lookup_time_seconds, which is the
wrong metric for this check, as that is reporting the time it takes to
resolve the _target_, which is the DNS *server*. Since we normally pass
an IP address as the target, that resolution time is very low
(microseconds).

The change in blackbox_exporter is in this PR:

prometheus/blackbox_exporter#662

Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
@mem mem force-pushed the probe_dns_duration_seconds branch from fedcd88 to 3192f79 Compare July 13, 2020 15:00
mem added a commit to grafana/synthetic-monitoring-app that referenced this pull request Jul 13, 2020
This PR:

grafana/synthetic-monitoring-agent#54

uses an updated version of blackbox_exporter that exposes a metric
called "probe_dns_duration_seconds", which is the time it takes for DNS
check to complete from connection to getting back the RR from the DNS
server. The metric has a label "phase" with three different values for
each phase of the query, just like probe_http_duration_seconds.

Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
@mem mem merged commit bf8755e into master Jul 13, 2020
@mem mem deleted the probe_dns_duration_seconds branch July 13, 2020 16:55
mem added a commit to grafana/synthetic-monitoring-app that referenced this pull request Jul 13, 2020
This PR:

grafana/synthetic-monitoring-agent#54

uses an updated version of blackbox_exporter that exposes a metric
called "probe_dns_duration_seconds", which is the time it takes for DNS
check to complete from connection to getting back the RR from the DNS
server. The metric has a label "phase" with three different values for
each phase of the query, just like probe_http_duration_seconds.

Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
mem added a commit to grafana/synthetic-monitoring-app that referenced this pull request Jul 13, 2020
This PR:

grafana/synthetic-monitoring-agent#54

uses an updated version of blackbox_exporter that exposes a metric
called "probe_dns_duration_seconds", which is the time it takes for DNS
check to complete from connection to getting back the RR from the DNS
server. The metric has a label "phase" with three different values for
each phase of the query, just like probe_http_duration_seconds.

Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants