-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use blackbox_exporter with probe_dns_duration_seconds #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mem
added a commit
to grafana/synthetic-monitoring-app
that referenced
this pull request
Jul 9, 2020
This PR: grafana/synthetic-monitoring-agent#54 uses a forked version of blackbox_exporter that exposes a metric called "probe_dns_duration_seconds", which is the time it takes for DNS check to complete from connection to getting back the RR from the DNS server. Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
mem
added a commit
to grafana/synthetic-monitoring-app
that referenced
this pull request
Jul 9, 2020
This PR: grafana/synthetic-monitoring-agent#54 uses a forked version of blackbox_exporter that exposes a metric called "probe_dns_duration_seconds", which is the time it takes for DNS check to complete from connection to getting back the RR from the DNS server. Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
woodsaj
approved these changes
Jul 13, 2020
Given this change was merged upstream, looks like we should just vendor in |
The forked version of blackbox_exporter exposes a metric called "probe_dns_duration_seconds", which is the time it takes for the DNS check to run, from connection to query and getting results back. Currently SM is relying on probe_dns_lookup_time_seconds, which is the wrong metric for this check, as that is reporting the time it takes to resolve the _target_, which is the DNS *server*. Since we normally pass an IP address as the target, that resolution time is very low (microseconds). The change in blackbox_exporter is in this PR: prometheus/blackbox_exporter#662 Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
mem
force-pushed
the
probe_dns_duration_seconds
branch
from
July 13, 2020 15:00
fedcd88
to
3192f79
Compare
mem
added a commit
to grafana/synthetic-monitoring-app
that referenced
this pull request
Jul 13, 2020
This PR: grafana/synthetic-monitoring-agent#54 uses an updated version of blackbox_exporter that exposes a metric called "probe_dns_duration_seconds", which is the time it takes for DNS check to complete from connection to getting back the RR from the DNS server. The metric has a label "phase" with three different values for each phase of the query, just like probe_http_duration_seconds. Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
mem
added a commit
to grafana/synthetic-monitoring-app
that referenced
this pull request
Jul 13, 2020
This PR: grafana/synthetic-monitoring-agent#54 uses an updated version of blackbox_exporter that exposes a metric called "probe_dns_duration_seconds", which is the time it takes for DNS check to complete from connection to getting back the RR from the DNS server. The metric has a label "phase" with three different values for each phase of the query, just like probe_http_duration_seconds. Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
mem
added a commit
to grafana/synthetic-monitoring-app
that referenced
this pull request
Jul 13, 2020
This PR: grafana/synthetic-monitoring-agent#54 uses an updated version of blackbox_exporter that exposes a metric called "probe_dns_duration_seconds", which is the time it takes for DNS check to complete from connection to getting back the RR from the DNS server. The metric has a label "phase" with three different values for each phase of the query, just like probe_http_duration_seconds. Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The forked version of blackbox_exporter exposes a metric called
"probe_dns_duration_seconds", which is the time it takes for the DNS
check to run, from connection to query and getting results back.
Currently SM is relying on probe_dns_lookup_time_seconds, which is the
wrong metric for this check, as that is reporting the time it takes to
resolve the target, which is the DNS server. Since we normally pass
an IP address as the target, that resolution time is very low
(microseconds).
The change in blackbox_exporter is in this PR:
prometheus/blackbox_exporter#662
Signed-off-by: Marcelo E. Magallon marcelo.magallon@grafana.com