Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: allow checks to run less often #611

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

mem
Copy link
Contributor

@mem mem commented Feb 9, 2024

This change allows a check to run less often by storing the produced metrics and pushing the last set that was produced by the scraper once every 2 minutes.

@mem mem requested a review from a team as a code owner February 9, 2024 23:59
Copy link
Contributor

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was nice! 👏 Made a couple of comments.

internal/scraper/scraper_test.go Outdated Show resolved Hide resolved
pkg/pb/synthetic_monitoring/checks_extra.go Show resolved Hide resolved
internal/scraper/scraper.go Show resolved Hide resolved
@mem mem requested a review from ka3de February 28, 2024 19:13
@mem mem force-pushed the allow-lower-frequencies branch from 8cdacf0 to 07ec23c Compare March 5, 2024 14:44
This change allows a check to run less often by storing the produced
metrics and pushing the last set that was produced by the scraper once
every 2 minutes.

Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
@mem mem force-pushed the allow-lower-frequencies branch from 07ec23c to b61761a Compare March 5, 2024 14:50
@mem mem merged commit abb5ff6 into main Mar 5, 2024
4 checks passed
@mem mem deleted the allow-lower-frequencies branch March 5, 2024 14:55
ka3de added a commit that referenced this pull request Mar 11, 2024
* Send adhoc check done logs to Loki without --verbose (#631)
* Chore(deps): Bump github.com/prometheus/prometheus from 0.50.0 to 0.50.1
* Configure blacklist ip range for k6 runner (#633)
* Add telemetry (#621)
* Fix: telemetry region label (#638)
* Chore(deps): Bump github.com/stretchr/testify from 1.8.4 to 1.9.0 (#640)
* Chore(deps): Bump google.golang.org/grpc from 1.61.1 to 1.62.0 (#628)
* Chore(deps): Bump golang.org/x/net from 0.21.0 to 0.22.0 (#642)
* Chore(deps): Bump github.com/prometheus/common from 0.47.0 to 0.49.0
* use expfmt.NewFormat instead of now-private formats directly
* Feature: allow checks to run less often (#611)
* Upgrade to grafana-build-tools v0.6.1 (#646)
* Fix telemetry error handling (#650)
* Use github.com/grafana/loki/pkg/pusher instead of logproto (#648)
* Pass a scraper factory from main (#649)
* Chore(deps): Bump google.golang.org/grpc from 1.62.0 to 1.62.1
* Chore(deps): Bump github.com/prometheus/common from 0.49.0 to 0.50.0
* Add telemetry sampled executions (#653)

Signed-off-by: ka3de <danijs12@hotmail.com>
@ka3de ka3de mentioned this pull request Mar 11, 2024
ka3de added a commit that referenced this pull request Mar 11, 2024
* Send adhoc check done logs to Loki without --verbose (#631)
* Chore(deps): Bump github.com/prometheus/prometheus from 0.50.0 to 0.50.1
* Configure blacklist ip range for k6 runner (#633)
* Add telemetry (#621)
* Fix: telemetry region label (#638)
* Chore(deps): Bump github.com/stretchr/testify from 1.8.4 to 1.9.0 (#640)
* Chore(deps): Bump google.golang.org/grpc from 1.61.1 to 1.62.0 (#628)
* Chore(deps): Bump golang.org/x/net from 0.21.0 to 0.22.0 (#642)
* Chore(deps): Bump github.com/prometheus/common from 0.47.0 to 0.49.0
* use expfmt.NewFormat instead of now-private formats directly
* Feature: allow checks to run less often (#611)
* Upgrade to grafana-build-tools v0.6.1 (#646)
* Fix telemetry error handling (#650)
* Use github.com/grafana/loki/pkg/pusher instead of logproto (#648)
* Pass a scraper factory from main (#649)
* Chore(deps): Bump google.golang.org/grpc from 1.62.0 to 1.62.1
* Chore(deps): Bump github.com/prometheus/common from 0.49.0 to 0.50.0
* Add telemetry sampled executions (#653)

Signed-off-by: ka3de <danijs12@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants