Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove static max check labels verification #659

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Remove static max check labels verification #659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions pkg/pb/synthetic_monitoring/checks_extra.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ var (
ErrInvalidCheckFrequency = errors.New("invalid check frequency")
ErrInvalidCheckTimeout = errors.New("invalid check timeout")
ErrInvalidCheckLabelName = errors.New("invalid check label name")
ErrTooManyCheckLabels = errors.New("too many check labels")
ErrInvalidCheckLabelValue = errors.New("invalid check label value")
ErrInvalidLabelName = errors.New("invalid label name")
ErrInvalidLabelValue = errors.New("invalid label value")
Expand Down Expand Up @@ -131,7 +130,6 @@ const (
const (
MaxMetricLabels = 20 // Prometheus allows for 32 labels, but limit to 20.
MaxLogLabels = 15 // Loki allows a maximum of 15 labels.
MaxCheckLabels = 10 // Allow 10 user labels for checks,
MaxProbeLabels = 3 // 3 for probes, leaving 7 for internal use.
maxValidLabelValueLength = 2048 // This is the actual max label value length.
MaxLabelValueLength = 128 // Keep this number low so that the UI remains usable.
Expand Down Expand Up @@ -376,10 +374,6 @@ func (c Check) validateTimeout() error {
}

func validateLabels(labels []Label) error {
if len(labels) > MaxCheckLabels {
return ErrTooManyCheckLabels
}

seenLabels := make(map[string]struct{})

for _, label := range labels {
Expand Down