Bump Go to 1.22 #699
Merged
Bump Go to 1.22 #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has no effect on the released images because those are already using Go 1.21, but it's nice to keep stuff in sync. Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
The-9880
reviewed
Apr 30, 2024
| @@ -1,6 +1,6 @@ | |||
| module github.com/grafana/synthetic-monitoring-agent | |||
|
|
|||
| go 1.21 | |||
| go 1.22 | |||
There was a problem hiding this comment.
Should we put down 1.22.0 instead? I have 1.22.2 locally and I find without the full release version, it keeps pestering me about there not being a toolchain for 1.22 (my GOTOOLCHAIN is auto)
There was a problem hiding this comment.
really?
let me look at what the logs say...
There was a problem hiding this comment.
the logs for the build do not say anything because I force GOTOOLCHAIN to local.
There was a problem hiding this comment.
I'll look at this later.
The-9880
approved these changes
Apr 30, 2024
Merged
mem
added a commit
that referenced
this pull request
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has no effect on the released images because those are already using Go 1.21, but it's nice to keep stuff in sync.