Move browser Docker build into separate Dockerfile #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the browser release build instructions into a separate Dockerfile which drone can target for browser build steps.
|
Hold on, I think I see something 🤦♂️ |
nadiamoe
approved these changes
Sep 13, 2024
Comment on lines
+200
to
+201
| // TODO(the-9880): remove after release fix confirmed | ||
| docker_publish_with_browser(gcrio_repo, grcio_auth, 'gcr.io', 'linux', 'amd64') + devAndRelease, |
There was a problem hiding this comment.
Just a reminder so we don't forget about the TODO
nadiamoe
added a commit
that referenced
this pull request
Sep 19, 2024
* Update module github.com/prometheus/common to v0.58.0 * Output unadorned version tag for releases (#862) * Update debian:stable-slim Docker digest to 64bc71f (#867) * Update module github.com/prometheus/client_golang to v1.20.3 (#869) * Update module github.com/prometheus/common to v0.59.1 (#870) * Update module golang.org/x/net to v0.29.0 * Update alpine:3.20 Docker digest to beefdbd (#874) * Update github.com/grafana/loki/pkg/push digest to 0780456 (#876) * Update golang.org/x/exp digest to e7e105d (#877) * Update renovatebot/github-action action to v40.2.8 * scripts: update go to 1.23 * Update module google.golang.org/grpc to v1.66.1 (#884) * Update module google.golang.org/grpc to v1.66.2 (#885) * Move browser Docker build into separate Dockerfile (#886) * Stop publishing browser image to GCR (#888) * Update grafana-build-tools to 0.23.1 (#889) * Migrate base image from Debian to Alpine (#875) * k6runner: error if script timeout is not set * scraper: use check frequency as the context deadline for k6 checks * scraper/test: work around panic if all settings are nil in test * k6runner/http: override only logger in WithLogger * k6runner/http: retry requests * k6runner: promote log messages surfacing errors to warning level * Update renovatebot/github-action action to v40.2.10 (#891) * Update module github.com/prometheus/client_golang to v1.20.4 (#893) * scripts/go: update gosec to v2 proper * Update module github.com/mccutchen/go-httpbin/v2 to v2.15.0 Signed-off-by: Nadia Santalla <nadia@santalla.io>
Merged
nadiamoe
added a commit
that referenced
this pull request
Sep 19, 2024
* Update module github.com/prometheus/common to v0.58.0 * Output unadorned version tag for releases (#862) * Update debian:stable-slim Docker digest to 64bc71f (#867) * Update module github.com/prometheus/client_golang to v1.20.3 (#869) * Update module github.com/prometheus/common to v0.59.1 (#870) * Update module golang.org/x/net to v0.29.0 * Update alpine:3.20 Docker digest to beefdbd (#874) * Update github.com/grafana/loki/pkg/push digest to 0780456 (#876) * Update golang.org/x/exp digest to e7e105d (#877) * Update renovatebot/github-action action to v40.2.8 * scripts: update go to 1.23 * Update module google.golang.org/grpc to v1.66.1 (#884) * Update module google.golang.org/grpc to v1.66.2 (#885) * Move browser Docker build into separate Dockerfile (#886) * Stop publishing browser image to GCR (#888) * Update grafana-build-tools to 0.23.1 (#889) * Migrate base image from Debian to Alpine (#875) * k6runner: error if script timeout is not set * scraper: use check frequency as the context deadline for k6 checks * scraper/test: work around panic if all settings are nil in test * k6runner/http: override only logger in WithLogger * k6runner/http: retry requests * k6runner: promote log messages surfacing errors to warning level * Update renovatebot/github-action action to v40.2.10 (#891) * Update module github.com/prometheus/client_golang to v1.20.4 (#893) * scripts/go: update gosec to v2 proper * Update module github.com/mccutchen/go-httpbin/v2 to v2.15.0 Signed-off-by: Nadia Santalla <nadia@santalla.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: realized the issue and revamped the PR.
Turns out the
targetfor the multi-stage Dockerfile was not being set when publishing it - we were only setting it when doing the dry-run build. This explains why both images on Dockerhub included chromium.This updates the
targetwhen publishing the image. Additionally publishes the browser image to GCR so we can confirm this works ASAP. When confirmed, I will remove that addition.