Fix: Revert to v1.16.9 #1027
Merged
Fix: Revert to v1.16.9 #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,3 +1,3 @@ | |||
| { | |||
| ".": "1.16.10" | |||
| ".": "1.16.9" | |||
There was a problem hiding this comment.
Will this cause issues when try to release? (I'm assuming we'll have to release as 1.16.11)
There was a problem hiding this comment.
Probably it would fail, in a following commit I changed the version back to 1.16.10 as it was reverted automatically when running git revert v1.16.9..HEAD
CHANGELOG.md
Outdated
|
|
||
| * **deps:** bump nanoid from 3.3.7 to 3.3.8 ([#1018](https://github.com/grafana/synthetic-monitoring-app/issues/1018)) ([77032d0](https://github.com/grafana/synthetic-monitoring-app/commit/77032d060323c49ed68394a6e242b0b6aa528d29)) | ||
| * update checks UI styling ([#1020](https://github.com/grafana/synthetic-monitoring-app/issues/1020)) ([2b69b02](https://github.com/grafana/synthetic-monitoring-app/commit/2b69b024e2759e862b6c1cc490e4490ccf4f4df4)) | ||
|
|
||
| ## [1.16.9](https://github.com/grafana/synthetic-monitoring-app/compare/v1.16.8...v1.16.9) (2024-11-29) |
There was a problem hiding this comment.
Should keep 1.16.10 details if we are releasing as 1.16.11?
There was a problem hiding this comment.
Good catch. Added it back.
peterschretlen
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
v1.16.10we introduced an issue where checks can't be saved if the Test button is clicked first.This happens because the Test button submits the form, but it just doesn't save anything. So the form logic believes that there are no unsaved changes, hence why the handling of "unsaved changes" fails.
Since we're currently on code freeze until Jan 6, 2025, I'm rolling back all changes until the previous working version which is
v1.16.9.