Add oauth2 fields behind a feature flag #609
Conversation
There was a problem hiding this comment.
I assume the backend isn't set up for this yet as I could see it in the request but didn't return any of the options I had added.
I left a comment about what my expectation of the "Use Oauth2" checkbox should do after you untick it but when it is ticked my other expectation is that some of the fields should be required at that point but they can all be sent empty?
The UI is pretty cramped, could do with a bit of margin-bottom to separate the forms from the tickboxes.
| disabled={!isEditor} | ||
| /> | ||
| </VerticalGroup> | ||
| <IconButton name="minus-circle" onClick={() => removeEndpointParam(index)} /> |
There was a problem hiding this comment.
This is missing a 'Delete' tooltip. (Same as the IconButton below). This button also isn't centred but top aligned.
| ` | ||
| } | ||
| value={includeOauth2} | ||
| onChange={() => setIncludeOauth2(!includeOauth2)} |
There was a problem hiding this comment.
I noticed when testing this my expectation of what this checkbox does versus what it is actually doing don't quite line up. If you tick this, start filling in the form, change your mind and untick it my expectation would be that none of the fields would be sent with the request but I can see that they are still.
It is worth noting, I think it is good to persist the fields in case someone accidentally unticks this and then wants to get back the information they have just added but I think it is a fair expectation that once they submit with this box unticked that any information within the oauth2 fields is lost.
| size="sm" | ||
| disabled={!isEditor} | ||
| onClick={() => { | ||
| console.log('appending scope'); |
|
Yeah this one is in limbo and I've been meaning to come back to it when I carve out some time. The backend supports it but might require some changes, and I need a good test case |
|
Closing this for now, this got a little too stale |
No description provided.