fix: add a description tooltip to uptime and reachability stats #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckbedwell
reviewed
Oct 26, 2023
rdubrock
force-pushed
the
add-big-value-header
branch
from
a82ce56 to
e31bfc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the feedback on the first try! Here's the next take. It's still a little small on the probes view, but overall much better than the first attempt:
I opted not to wrap BigValue, but instead just created a BigValueTitle component. Wrapping BigValue felt like it was an opportunity to redefine the API of the BigValue component, but that was more bite than I wanted to chew today 😅. Happy to change that if it feels important.