-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser checks dashboard - Iteration 3 #931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes a big difference so thank you for turning it round so fast ⚡
In terms of the UI, my preference would be adapting the web vital gauge so it is more in line with the other panels; so the explore link is in the three-dot hover menu on the panel. I found it a little jarring that the pattern is different to all the other panels on the page.
It shouldn't be too difficult to bring in <PanelChrome />
from @grafana/ui
so most of the behaviour is baked in by default in that component but I was looking at src/scenes/ExplorablePanel
and wondering if this was usable with a custom component rather than having to provide a pluginId?
Lastly, the Explore link should stay in the same tab and not open a new one with target=_blank
.
Thanks for your feedback @ckbedwell! I went ahead and used the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💪
Improvements to the browser checks dashboard:
Adds explore links in web vitals panels so users can see how the number is calculated by getting access to the query in Explore.
Removes the unit in the CLS column of the web vitals by url table
Part of #866
Addresses #918 (review)