Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add private preview badge to browser checks #935

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

VikaCep
Copy link
Contributor

@VikaCep VikaCep commented Sep 13, 2024

  • Adds a private preview badge to the browser checks option in the Check Creation view
    image

  • Adds banner on the create/edit form for Browser Checks indicating usage is free for private preview.
    image

Closes https://github.com/grafana/synthetic-monitoring/issues/146

@VikaCep VikaCep self-assigned this Sep 13, 2024
@VikaCep VikaCep requested a review from a team as a code owner September 13, 2024 20:23
@VikaCep VikaCep requested a review from ckbedwell September 13, 2024 20:23
@ckbedwell
Copy link
Contributor

Because of the hard deadline we have I thought I'd help by making a branch with my suggestions rather than writing them out (hopefully that is okay!): #936

Copy link
Contributor

@ckbedwell ckbedwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VikaCep VikaCep merged commit b8ce010 into main Sep 18, 2024
5 checks passed
@VikaCep VikaCep deleted the browser-checks-public-preview-badge branch September 18, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants